]> dgit.raspbian.org Git - gnome-shell.git/commit
appDisplay: Do not bind popdown call to grabHelper onUngrab
authorMarco Trevisan (Treviño) <mail@3v1n0.net>
Thu, 4 Feb 2021 16:37:02 +0000 (17:37 +0100)
committerMarco Trevisan (Treviño) <mail@3v1n0.net>
Thu, 4 Feb 2021 20:55:34 +0000 (21:55 +0100)
commite641547ddf2c2afb42b4f2d3f250d84e1463a710
tree05093f5fe18f9d4f27de77b43276f9a2be78b146
parentf5b622a703689fbb72ff2e66bebfe313ce072bb0
appDisplay: Do not bind popdown call to grabHelper onUngrab

grabHelper is passing a boolean argument to onUngrab() callback function
and since commit 1acbdcc9b3b0 we'd end up adding it to to the callback list or
we'd try to invoke it:

 (gnome-shell:3490851): Gjs-CRITICAL **: 17:19:20.460: JS ERROR:
  TypeError: func is not a function
  onComplete/<@/media/M2/GNOME/gnome-shell/js/ui/appDisplay.js:2407:56
  onComplete@/media/M2/GNOME/gnome-shell/js/ui/appDisplay.js:2407:40
  _makeEaseCallback/<@/media/M2/GNOME/gnome-shell/js/ui/environment.js:85:13
  _easeActor/<@/media/M2/GNOME/gnome-shell/js/ui/environment.js:170:64

Use an arrow function so that we can control the parameters we pass
to popdown.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1635>
js/ui/appDisplay.js